Repository navigation
Conversation
YellowNest
reviewed
Oct 7, 2026
YellowNest
left a comment
There was a problem hiding this comment.
I had a look. The teardown itself is the right idea, but I think reusing ClearSettingsTreeItemAccessibility() for CHILDID_SELF changes its existing runtime semantics.
That helper is also called during normal tree rebuilds, not only destruction:
CTreeSettingsDlg::SetGroup()callsSetSettingsTreeAccessibleName()and thenClearSettingsTreeItemAccessibility(). With this change, the latter immediately clears the tree-level name that was just set.CSkinSettingsDlg::InitSkinUI()also calls it before rebuilding the tree. ClearingCHILDID_SELFthere removes theANNO_CONTAINERCSettingsTreeAccServer, and I don't see it being re-advised after the rebuild.
So I think item cleanup and final tree teardown should stay separate: keep the existing helper item-only for rebuilds, and clear CHILDID_SELF only from the destroy path. That avoids changing accessibility behavior while the dialog remains alive.
Member
Author
|
Oki, fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2556