Repository navigation
Release settings accessibility servers before DLL unload - #40
Draft
YellowNest wants to merge 1 commit into
Draft
YellowNest wants to merge 1 commit into
YellowNest wants to merge 1 commit into
Conversation
YellowNest
force-pushed
the
fix/settings-accessibility-server-lifetime
branch
from
October 7, 2026 19:15
f374cb0 to
bde7bf0
Compare
YellowNest
force-pushed
the
fix/settings-accessibility-server-lifetime
branch
from
October 7, 2026 19:16
51e504b to
34cc2c2
Compare
|
I have created Open-Shell#2557 PR in the meantime. Can you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release the MSAA dynamic-annotation servers owned by the settings trees before their hosting DLL can be unloaded.
Root cause
The accessibility work from Open-Shell#2518 registers
CSettingsTreeAccServerinstances throughIAccPropServices::SetHwndPropServer.Those registrations can outlive the settings dialog unless they are explicitly cleared. After Open-Shell exits,
StartMenuDLLmay be unloaded whileoleaccstill retains marshaled references to those servers. A later accessibility annotation can triggerCPropMgrImpl::Clean, which then attempts to callCSettingsTreeAccServer::Release()through the stale vtable address in the unloaded module.That matches the crash in Open-Shell#2556.
Changes
Validation
Static review completed against current upstream master. Build and runtime validation pending.