[18.0][FIX] mail_composer_cc_bcc: don't skip cc/bcc just for notification - #256
Open
qgroulard wants to merge 1 commit into
Open
[18.0][FIX] mail_composer_cc_bcc: don't skip cc/bcc just for notification#256qgroulard wants to merge 1 commit into
qgroulard wants to merge 1 commit into
Conversation
…otification _notify_thread set skip_adding_cc_bcc=True for every message_type == "notification" message, to stop cc/bcc leaking onto incidental system-generated side messages (e.g. a field-tracking notification posted via write() on the same is_from_composer-tainted env as an RFQ send. See 3b97ab2, which introduced this). But message_type alone can't distinguish that case from a message that IS the one actually being sent, just categorized as "notification" (which is message_post_with_source()'s own default message_type).
Contributor
|
Hi @trisdoan, |
OCA-git-bot
added
series:18.0
mod:mail_composer_cc_bcc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_notify_thread set skip_adding_cc_bcc=True for every message_type == "notification" message, to stop cc/bcc leaking onto incidental system-generated side messages (e.g. a field-tracking notification posted via write() on the same is_from_composer-tainted env as an RFQ send. See 3b97ab2, which introduced this).
But message_type alone can't distinguish that case from a message that IS the one actually being sent, just categorized as "notification" (which is message_post_with_source()'s own default message_type).