[18.0][FIX] mail_composer_cc_bcc: keep the "View <record>" button for internal user recipients - #265
Open
qgroulard wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @trisdoan, |
OCA-git-bot
added
series:18.0
mod:mail_composer_cc_bcc
…nal user recipients
Every recipient added through the composer (original recipients, plus
the cc/bcc partners) was unconditionally classified as "customer".
A side effect: the "View <record>" button Odoo normally shows to
internal user recipients was hidden for everyone, since that button is
tied to the "user" notification group, which was never allowed to
survive.
Let partners keep their real usage ("user", "portal" or "customer")
Internal users now get their own notification email with the button,
while external recipients still share a single button-less email.
Thus we now have two mail.mail (one for users, and one for the others)
sharing the same mail.message.
The To/Cc/Bcc headers stay identical on both, regardless of which
notification group produced the mail.mail.
qgroulard
force-pushed
the
18.0-fix-mail_composer_cc_bcc_message_type-qgr
branch
from
September 10, 2026 11:54
0a4d80b to
f182ce3
Compare
Contributor
Author
|
Hi @trisdoan, I didn't expect that the installation of this module on my instance would lead to that many bugs. I think they are pretty serious side-effects that deserve to be reviewed quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #264
Every recipient added through the composer (original recipients, plus the cc/bcc partners) was unconditionally classified as "customer".
A side effect: the "View " button Odoo normally shows to internal user recipients was hidden for everyone, since that button is tied to the "user" notification group, which was never allowed to survive.
Let partners keep their real usage ("user", "portal" or "customer") Internal users now get their own notification email with the button, while external recipients still share a single button-less email. Thus we now have two mail.mail (one for users, and one for the others) sharing the same mail.message.
The To/Cc/Bcc headers stay identical on both, regardless of which notification group produced the mail.mail.