Skip to content

cloudxr: Update badge to just say 6 and split into CloudXR runtime and CloudXR.js - #1385

Open
nv-jakob wants to merge 1 commit into
mainfrom
jakob/cloudxr-badges
Open

nv-jakob wants to merge 1 commit into
mainfrom
jakob/cloudxr-badges

Conversation

@nv-jakob

@nv-jakob nv-jakob commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Testing

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Documentation
    • Updated release documentation badges to show explicit Isaac Teleop and Isaac Lab versions for supported release branches.
    • CloudXR Runtime and CloudXR.js now appear as separate badges, both showing major version 6 and linking to their respective documentation.
    • CloudXR Runtime links to the SDK root by default, while CloudXR.js links to the latest guide.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between eb0d486 and 5ddf36f.

Files selected for processing: 2
  • docs/AGENTS.md
  • docs/source/conf.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The documentation configuration now defines separate CloudXR Runtime and CloudXR.js badges. Both display major version 6 and use separate documentation links. The configuration applies release-6 links to the listed release branches. Badge guidance now specifies explicit Isaac Teleop and Isaac Lab versions, separate CloudXR badges, and the SDK pin location.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • NVIDIA/IsaacCapture#1365: Updates the CloudXR.js SDK pin; this PR adds a CloudXR.js badge for the same SDK family.
  • NVIDIA/IsaacCapture#1359: Updates the CloudXR runtime SDK; this PR adds a runtime badge for that release family.
  • NVIDIA/IsaacCapture#1326: Updates the CloudXR runtime SDK to a release candidate; this PR adds a runtime badge for that release family.
Merge Risk: Minimal · previous review 5ddf3

The badges now show CloudXR 6. Historical release-branch versions could not be verified in the available checkout.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: updating the CloudXR badge to show version 6 and splitting it into CloudXR runtime and CloudXR.js badges.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

✅ Preview deployed: https://NVIDIA.github.io/IsaacCapture/preview/pr-1385/

Built from commit a971cf3. It may take a minute for the updated preview to appear.

Signed-off-by: Jakob Bornecrantz <tbornecrantz@nvidia.com>

@ivany-nv ivany-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiwenc-nv

Copy link
Copy Markdown
Collaborator

good idea... so much simpler...

This branch was successfully deployed

1 active deployment
dev — a971cf3a Deployed Oct 28, 2026 by nv-jakob via publish-wheel #6162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants