Skip to content

Ground tour questions in reachable behavior - #47

Merged
rcosteira79 merged 1 commit into
mainfrom
fix/tour-question-grounding
Nov 11, 2026
Merged

rcosteira79 merged 1 commit into
mainfrom
fix/tour-question-grounding

Conversation

@rcosteira79

Copy link
Copy Markdown
Collaborator

Tour explanations could turn a payload-free state into an unsupported transition claim, then ask the reviewer to resolve a problem the repository already rules out. For example, Retrying carrying no data does not establish that Shown can enter it or lose content.

Make review questions optional and require their premises to be traced through callers, guards, state writers, and consumers. Apply the same rule to planning and explanation prompts, provide captured Git identities for supporting source, and treat generated objectives as route context rather than facts. Distinguish planned transitions and direct test-state assignments from implemented production paths. Update the attached-agent instructions to match.

Validation: typecheck and 41 focused agent, syntax-evidence, and skill tests passed. Added and prepared three real-model evaluation fixtures covering guarded retries, planned transitions without a controller, and an actually reachable content-dropping retry. Model evaluations have not been run; this changes the generation contract and does not add a deterministic semantic validator or prove model compliance. The reported live review was inspected read-only and was not modified, regenerated, or closed.

@rcosteira79
rcosteira79 merged commit 61a733d into main Nov 11, 2026
14 checks passed
@rcosteira79
rcosteira79 deleted the fix/tour-question-grounding branch November 13, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant