Repository navigation
Wait for Monaco navigation before clicking change summaries - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main push after #47 failed in the Monaco summary browser test even though the PR passed. It clicked What changed immediately after selecting a file, while lazy editor mounting and navigation could still shift the button. The summary request was never sent, so the test eventually timed out waiting for an error panel.
Await the existing asynchronous file-reveal path before opening summaries, and explicitly require the summary request. Keep the existing retry/rerender, source-link, export, and draft assertions. Save a Playwright trace and summary-request diagnostics on failure, and include the trace in CI's failure artifacts.
Validation: reproduced the same timeout in an isolated fixture by delaying the preceding editor mount. Pointer-down hit the summary button; pointer-up/click hit its header, and no request was sent. The same controlled reproduction passed with the readiness wait. The complete updated browser script passed locally; JavaScript syntax and diff checks passed. No runtime application behavior changed, no retries or longer assertion timeouts were added, and no live review was touched.
Failed run: https://github.com/Mindera/diffcompass/actions/runs/43112790938