Skip to content

fix(copy-page): scope table cell queries to direct children #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dj-jarvis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(copy-page): scope table cell queries to direct children #3066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/CopyPageButton/CopyPageButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const tableToMarkdown = tableEl => {
)
if (rows.length === 0) return ''

const firstRowCells = Array.from(rows[0].querySelectorAll('th, td'))
const firstRowCells = Array.from(rows[0].querySelectorAll(':scope > th, :scope > td'))
const headers = firstRowCells.map(cell => cell.textContent.trim())
let md = ''

Expand All @@ -67,7 +67,12 @@ const tableToMarkdown = tableEl => {

const bodyRows = rows.slice(1)
bodyRows.forEach(tr => {
const cells = Array.from(tr.querySelectorAll('th, td')).map(td => td.textContent.trim())
// `:scope` is required so cells belonging to a table nested inside a cell
// (for example a Markdown table used inside a table cell) are not pulled
// into the outer row and shift every following column.
const cells = Array.from(tr.querySelectorAll(':scope > th, :scope > td')).map(td =>
td.textContent.trim()
)
md += `| ${cells.join(' | ')} |\n`
})

Expand Down