Repository navigation
Conversation
|
Someone is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
src/components/CopyPageButton/CopyPageButton.jsx,tableToMarkdowncollected each row's cells with a descendant selector:'th, td'matches at any depth, not just direct children. The row selection a few lines above already uses:scope >correctly, so the two were inconsistent.Impact
<tr>. They get collected as extra columns, so the emitted row has more cells than the header row and is not valid Markdown.buildMarkdown()feeds the "Copy page as Markdown for LLMs", "View as Markdown", and "Open in Claude/ChatGPT/Perplexity" actions. A malformed table therefore reaches the clipboard, the preview window, and the AI query string, where the model can misread which value belongs to which parameter.Fix
Add
:scope >to both cell selectors so only the row's own cells are used:This aligns cell selection with the existing
:scope > thead > trrow selection.