Skip to content

fix(discourse): don't match a topic when the title is empty #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dj-jarvis wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix(discourse): don't match a topic when the title is empty #3065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/DiscourseComment/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,14 @@ export default function DiscourseComment(props) {
? commonWords.length / Math.min(topicWords.size, metaWords.size)
: 0

// `String.includes('')` is always true, so an empty normalized value would
// match every topic in the category. Require both sides to be non-empty.
const titleMatch =
wordOverlap > 0.5 ||
topicTitleNorm.includes(metaTitleNorm) ||
metaTitleNorm.includes(topicTitleNorm)
(!!topicTitleNorm &&
!!metaTitleNorm &&
(wordOverlap > 0.5 ||
topicTitleNorm.includes(metaTitleNorm) ||
metaTitleNorm.includes(topicTitleNorm)))
const excerptMatch = topic.excerpt?.includes(embedUrl) || topic.excerpt?.includes(url)
const categoryMatch = topic.category_id === parseInt(DISCOURSE_CATEGORY_ID)

Expand Down