[dj-jarvis]

Don't match a Discourse topic when the page title is empty

Problem

In src/components/DiscourseComment/index.jsx, normalizeTitle coerces a missing title to an empty string:

const normalizeTitle = str =>
  str?.toLowerCase().replace(/[|:]/g, ' ').replace(/\s+/g, ' ').trim() || ''

That value then feeds the topic-matching comparison:

const titleMatch =
  wordOverlap > 0.5 ||
  topicTitleNorm.includes(metaTitleNorm) ||
  metaTitleNorm.includes(topicTitleNorm)

In JavaScript, String.prototype.includes('') always returns true — the empty string is a substring of everything.

Impact

• When metadata.title normalizes to '', metaTitleNorm.includes(topicTitleNorm) is true for any topic title. Combined with categoryMatch, .find() returns the first topic in the category — an arbitrary discussion unrelated to the page.
• The resulting topicId is passed to the Discourse embed, so another tutorial's comments render under this page. Readers can mistake them for a discussion of this material.
• The failure is silent: no console output, no build error, no test failure — it just returns a "successful" but wrong topic id.

The wordOverlap > 0.5 guard does not prevent this. With empty titles both word sets are empty, so wordOverlap is forced to 0 and the includes check alone decides the outcome.

title is optional in Docusaurus frontmatter, so frontMatter.title is undefined whenever an author omits it. Even a present title can normalize to '' if it consists solely of |, : or whitespace, since normalizeTitle strips exactly those characters.

Fix

Require both normalized titles to be non-empty before comparing:

const titleMatch =
  !!topicTitleNorm &&
  !!metaTitleNorm &&
  (wordOverlap > 0.5 ||
    topicTitleNorm.includes(metaTitleNorm) ||
    metaTitleNorm.includes(topicTitleNorm))

The guard sits ahead of the whole expression, so wordOverlap > 0.5 keeps its previous behaviour for non-empty titles while the empty-string false positive is removed.

[vercel]

Someone is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.