Skip to content

fix: pre-select project tag when navigating from overview card (#327) #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timdegroot1996 merged 1 commit into from
Sep 15, 2026
Merged

fix: pre-select project tag when navigating from overview card (#327) #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion robotframework_dashboard/js/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ function filter_runtags(runs) {
if (selectedTagSetting != '') {
for (const input of tagElements) {
input.checked = false;
if (input.id === selectedTagSetting) {
// checkbox ids are prefixed with "runTagCheckBox", the value holds the raw tag name
if (input.value === selectedTagSetting) {
input.checked = true;
}
}
Expand Down
13 changes: 12 additions & 1 deletion tests/robot/resources/keywords/dashboard-keywords.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ Open Overview Page
Wait For Elements State selector=id=overviewLatestRunsSection
Wait For Elements State selector=id=overviewTotalStatsSection

Enable Run Tags On Overview Page
Click selector=id=settings
Click selector=id=overview-tab
Click selector=id=switchRunTags
Click selector=id=closeSettings

Open Dashboard Page From Overview Project Card
[Arguments] ${project}
Click selector=id=overviewLatest${project}Card0
Wait For Elements State selector=id=runStatisticsSection

Open Compare Page
Click selector=id=menuCompare
Wait For Elements State selector=id=compareStatisticsSection
Expand Down Expand Up @@ -207,7 +218,7 @@ Validate Filter Settings

Open Filter Dialog
IF len("${runs}") Get Selected Options id=runs value == ${runs}
IF len("S{run_tags}")
IF len("${runTags}")
VAR @{selected_run_tags} @{EMPTY}
${elements} Get Elements selector=id=runTag >> css=input.form-check-input
FOR ${element} IN @{elements}
Expand Down
7 changes: 7 additions & 0 deletions tests/robot/testsuites/06_filters.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ Validate Dashboard Run Tags Filter
Validate Component id=runStatisticsSection name=runTagsFilterAmount folder=run
Should Show 1 Of 1 Runs

Validate Dashboard Run Tags Filter From Overview Project Card
Open Overview Page
Enable Run Tags On Overview Page
Open Dashboard Page From Overview Project Card project=project_1
Should Show 8 Of 8 Runs
Validate Filter Settings runTags=project_1

Validate Dashboard Date Filter
Set Date Filter fromDate=03132025 fromTime=1225am
Validate Component id=runStatisticsSection name=runDateFilter folder=run
Expand Down
Loading