fix: pre-select project tag when navigating from overview card (#327) - #328
Merged
Merged
Conversation
Run tag checkbox ids were prefixed with "runTagCheckBox" in #222, but filter_runtags still compared input.id against the bare project tag set by the overview card click. No checkbox matched, "All" got unchecked and the dashboard showed 0 runs with the tag filter indicator active. Compare input.value (raw tag name) instead. Adds a robot test that clicks a project card in run-tags mode and asserts the resulting filter state, and fixes a typo in Validate Filter Settings that made the runTags branch unconditional.
timdegroot1996
added a commit
that referenced
this pull request
Sep 16, 2026
…w skills (#329) * chore: move agent skills to .claude/skills and drop Copilot instructions Claude Code only auto-discovers skills under .claude/skills/<name>/SKILL.md; the flat .github/skills/*.md files were never listed and depended on the agent choosing to read them from a table. That is how the Docker-only rule for robot tests got missed in #328. - 19 flat files -> 14 skills with name/description frontmatter written as triggers. Merged: testing (robot + python + js, with Docker rule and CI diagnosis), dev-workflow, coding-standards. Folded architecture and gotchas into CLAUDE.md. - New skills: gh-issue (issue -> branch -> fix -> test -> review, commit gated on approval), add-db-column, add-cli-argument; add-graph checklist in dashboard-graphs. - Fixed stale content: script names (unittests/jstests), test paths, filter pipeline stages and tagMode, JS test coverage table, docs page map, example.sh, module tree, camelCase/snake_case contradiction. - CLAUDE.md: robot tests Docker-only with the reason (suites run the installed CLI, not the working tree); no Copilot references. - scripts/docker/run-in-container.{sh,bat}: only allocate a TTY when one exists so the wrappers work from CI and agent shells. - .gitignore: .claude/settings.local.json. * chore: drop add-db-column skill (too rare to warrant one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327
Problem
Clicking a project card on the Overview page (with "Display bars with projects by Tag" enabled) opened an empty Dashboard: "showing 0 of 0 runs", tag-filter indicator active, but the project tag not checked.
Root cause
#222 prefixed the run-tag checkbox ids with
runTagCheckBox(id="runTagCheckBox${value}"), butfilter_runtags()still comparedinput.id === selectedTagSetting, whereselectedTagSettingholds the bare tag (project_1). Nothing matched, every checkbox — including "All" — was unchecked, and the filter returned an empty list.Fix
Compare
input.value(the raw tag name) instead ofinput.id.Tests
Validate Dashboard Run Tags Filter From Overview Project Cardin06_filters.robot, with two readable keywords (Enable Run Tags On Overview Page,Open Dashboard Page From Overview Project Card). Verified in the Docker robot container: fails without the JS change, passes with it. Full06_filterssuite: 11/11 pass.Validate Filter Settings(len("S{run_tags}")→len("${runTags}")) that made the runTags branch unconditional.🤖 Generated with Claude Code