Skip to content

Fix epoll test cleanup on Python 3.15 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
honglei wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Draft

Fix epoll test cleanup on Python 3.15 #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/test_sockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import os
import pickle
import select
import socket
Expand Down Expand Up @@ -272,7 +273,9 @@ def test_socket_sync_remove(self):
# See https://github.com/MagicStack/uvloop/issues/61 for details

sock = socket.socket()
epoll = select.epoll.fromfd(self.loop._get_backend_id())
# Keep a separate descriptor for the backend epoll instance. The loop
# owns its descriptor and closes it when the loop is closed.
epoll = select.epoll.fromfd(os.dup(self.loop._get_backend_id()))

try:
cb = lambda: None
Expand All @@ -288,8 +291,8 @@ def test_socket_sync_remove(self):

finally:
sock.close()
self.loop.close()
epoll.close()
self.loop.close()

def test_add_reader_or_writer_transport_fd(self):
def assert_raises():
Expand Down
Loading