Fix epoll test cleanup on Python 3.15 - #758
Draft
honglei wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the test-owned
epollwrapper on a duplicate of uvloop's backend descriptor. The loop retains ownership of its descriptor and closes it itself.This preserves the existing assertion that
remove_reader()removes the socket from the same epoll instance, while avoiding a second close afterloop.close()on Python 3.15.Validation
On Ubuntu 24.04 with locally built uvloop
master:TestUVSockets.test_socket_sync_removepassesWhy draft
Current source builds and basic loop smoke tests on 3.15/3.15t, but this is only a test-cleanup prerequisite, not a claim of complete 3.15 support. The full 3.15t optional test dependencies are currently blocked upstream:
pyOpenSSL~=25.3.0resolves to cryptography 46.0.7, whose PyO3 build rejects Python 3.15 free-threaded. I will not add 3.15/3.15t CI or release-wheel targets until that complete suite can run green.