Skip to content

fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HeaTTap wants to merge 1 commit into from
+6 −6
Closed

fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions philote_mdo/general/explicit_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,12 @@ def ComputeGradient(self, request_iterator, context):
else:
self._discipline.compute_partials(inputs, jac)

for jac, value in jac.items():
for key, value in jac.items():
for b, e in get_chunk_indices(value.size, self._stream_opts.num_double):
yield data.VariableMessage(
continuous=data.Array(
name=jac[0],
subname=jac[1],
name=key[0],
subname=key[1],
type=data.kPartial,
start=b,
end=e - 1,
Expand Down
6 changes: 3 additions & 3 deletions philote_mdo/general/implicit_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,12 @@ def ComputeResidualGradients(self, request_iterator, context):
else:
self._discipline.residual_partials(inputs, outputs, jac)

for jac, value in jac.items():
for key, value in jac.items():
for b, e in get_chunk_indices(value.size, self._stream_opts.num_double):
yield data.VariableMessage(
continuous=data.Array(
name=jac[0],
subname=jac[1],
name=key[0],
subname=key[1],
type=data.kPartial,
start=b,
end=e,
Expand Down