Skip to content

fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs - #72

Closed
HeaTTap wants to merge 1 commit into
MDO-Standards:mainfrom
HeaTTap:fix/gradient-rpc-loop-var-shadowing
Closed

fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs#72
HeaTTap wants to merge 1 commit into
MDO-Standards:mainfrom
HeaTTap:fix/gradient-rpc-loop-var-shadowing

Conversation

@HeaTTap

@HeaTTap HeaTTap commented Jul 28, 2026

Copy link
Copy Markdown

Fixes #71

  • Renamed for jac, value in jac.items(): loop variable to for key, value in jac.items(): in philote_mdo/general/explicit_server.py and philote_mdo/general/implicit_server.py to prevent variable shadowing of the jac dictionary during gradient RPC streaming.

@chrislupp

Copy link
Copy Markdown
Collaborator

Until further notice, we are no longer accepting contributions from unknown developers. This is not how open source contributions are supposed to work.

@chrislupp chrislupp closed this Jul 28, 2026
@HeaTTap

HeaTTap commented Jul 28, 2026

Copy link
Copy Markdown
Author

Until further notice, we are no longer accepting contributions from unknown developers. This is not how open source contributions are supposed to work.

uh how is it supposed to work, i actually dont know
how do i beome a "known developer"?

@chrislupp

Copy link
Copy Markdown
Collaborator

I closed this PR because:

  • it was submitted without any prior discussion,
  • it implemented an issue that already documented the diagnosis and solution developed by another contributor,
  • it targeted the wrong branch (main instead of develop),
  • and it showed no indication that the project's development workflow had been reviewed before submitting code.

We will update our contribution policies soon to address issues like these, but in the mean time we need to restrict contribution to developers known to the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loop variable shadows the dict being iterated in both gradient RPCs

2 participants