fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs - #72
Closed
HeaTTap wants to merge 1 commit into
Closed
fix(server): rename loop variable to avoid shadowing jac dict in gradient RPCs#72HeaTTap wants to merge 1 commit into
HeaTTap wants to merge 1 commit into
Conversation
Collaborator
|
Until further notice, we are no longer accepting contributions from unknown developers. This is not how open source contributions are supposed to work. |
Author
uh how is it supposed to work, i actually dont know |
Collaborator
|
I closed this PR because:
We will update our contribution policies soon to address issues like these, but in the mean time we need to restrict contribution to developers known to the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
for jac, value in jac.items():loop variable tofor key, value in jac.items():inphilote_mdo/general/explicit_server.pyandphilote_mdo/general/implicit_server.pyto prevent variable shadowing of thejacdictionary during gradient RPC streaming.