Repository navigation
task: abort once after a motion error, not again on an old status copy - #4816
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
After a motion error task aborts. If its next status read from motion failed, task kept its old copy, still showing the error, and aborted a second time, dropping the command that had just come in. A failed read now reports an old copy as busy, not as an error, as it already did for done. tests/stale-motion-status slow-controller checks one abort per failed probe and that the next move runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a motion error, such as a G38.2 that ends without contact, task aborts. If its next status read from motion fails, task keeps its old copy, which still shows the error, and aborts a second time. That second abort also drops the command that just came in, for example the move sent after the failed probe.
A failed read already did not report an old copy as done (#4666); now it does not report it as an error either.
Test: tests/stale-motion-status slow-controller now runs five no-contact probes after its program, with slowkins making task's status reads fail after each one. It checks there is one abort per probe and that the next move runs. Master fails it 8 times out of 8; with the fix it passes every time, also under load. Full suite 368/368.