Repository navigation
hal: Update iocontrol to 64-bit clean operation - #4808
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update to iocontrol is mostly trivial. Almost all HAL accesses are
hal_set_*()operations that get extended automatically on write.There was exactly one
hal_get_si32(), which has been replaced byhal_get_si32_clamped(). The value read is an index that is not expected to be too large/small. However, in the internal handling it is assigned to int, where it could get inappropriately truncated. Better have it clamp to the defaultintsize.