Repository navigation
interp: G43.2 axis words are offsets, never a move - #4806
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
A line with axis words and no motion code moves in the modal motion mode, except when G43.1 takes the axis words as offsets. Since G43.2 takes axis words as well (2df2871), the check above lets them through for G43.2 too, but the line still became a move: after G0, "G43.2 X0 Y0" applied the offset and then went to X0 Y0. The documentation says G43.2 causes no motion. This is the first half of 0ed1bbd on master. The second half, which makes a motion code or another axis-word G-code on a G43.1 or G43.2 line an error, can refuse programs that run today and stays on master. tests/interp/machine-coord-params already checks that G43.1 leaves the machine position alone; it now checks G43.2 axis words under G0 and G1 as well. Reported by Sigma1912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.9 part of #4675: a G43.2 line with axis words also moves in the modal motion mode. Reported by Sigma1912 on the axis_mm sim and on real hardware:
enhance_block()keeps G43.1 out of the modal move, and this keeps G43.2 out too, as the documentation says: G43.2 causes no motion.#4675 also makes a motion code or another G-code that takes axis words on a G43.1 or G43.2 line an error. That can refuse programs that run today, so it stays on master and is not in this PR.
tests/interp/machine-coord-paramsalready checks that G43.1 leaves the machine position alone, and now checks G43.2 axis words under G0 and G1 too. Without this change,G43.2 X0 Y0moves to 0, 0, 3 there. interp, toolchanger, tool-info and abort pass.