Repository navigation
halcmd: warn about an arrow written against a name - #4803
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
"net lube-pump=> io.relay5" makes a signal named "lube-pump=>", since halcmd only drops an arrow that stands as its own word. The config loads, and the odd name only shows up later, when halcmd commands typed by hand cannot find the signal. net, linkps and linksp now warn about an argument that starts or ends with "=>" or "<=". A name with an arrow in the middle, like "in=>out", stays silent and still works. The linkps help text listed the arrows as '==>' and '<=='; halcmd drops only '=>', '<=' and '<=>', and takes '==>' as a name. Reported by dirkx in LinuxCNC#4645.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4645 for now with a warning, as discussed there.
net lube-pump=> io.relay5makes a signal namedlube-pump=>, since halcmd only drops an arrow that stands as its own word. The config loads, and the odd name only shows up later, when halcmd commands typed by hand cannot find the signal.net,linkpsandlinkspnow warn about an argument that starts or ends with=>or<=:The name is still accepted as before, so no existing config breaks. A name with an arrow in the middle, like
in=>out, stays silent and still works (the case @rmu75 raised).While checking this I found the
linkpshelp text listed the arrows as==>and<==. halcmd drops only=>,<=and<=>; I testednet a ==> siggen.0.sineand halcmd looks for a pin named==>. The help text now lists the right ones, and the man page says an arrow needs spaces around it.