Repository navigation
Conversation
Contributor
|
FWIW, no need to add 356 files. I think you could do that in one file, like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advantage:
Test duration goes down from 37s to 30s with -j32
Disadvantage:
354 runtime files that need to be in git
After #4782 merged:
Without this PR: 32s
With this PR: 28s
Not that much benefit any more on my PC, so in my opinion the added complexity is probably not worth the speedup.
I create a PR anyway due to the code is already there and it might be different on other PC's.