Skip to content

fix: isolate segment definitions by image - #1015

Open
PaulHax wants to merge 3 commits into
Kitware:mainfrom
PaulHax:image-segment-ownership
Open

PaulHax wants to merge 3 commits into
Kitware:mainfrom
PaulHax:image-segment-ownership

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Deleting or renaming a segment while viewing one base image also changed every other image, because all images shared one segment catalog. Each image now owns its segment definitions, order and selection, shared by Paint, rectangles, polygons and rulers on that image.

The first time an image is viewed or edited, it copies the previous image's definitions, order and selection with fresh identities and no masks or shapes. With no previous image it starts from the configured defaults. A copy counts as borrowed until something edits it. A restored set replaces a borrowed copy. A companion segmentation replaces it with the configured defaults and then binds its labels to them by name, so configured segments stay alongside the file's labels. Loading therefore never blocks editing, and a copy the user has already edited keeps its rows, with incoming labels binding by name.

Configuration, processing results and image removal are scoped to their destination images. Manifest 8.0.0 saves per-image membership, order, selection and defaults, and the migration splits older shared catalogs into independent per-image sets without duplicating voxels.

This replaces #1005 with the same per-image model but without deferred initialization or a loading state.

@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 8aa2482
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6aebe2948d36956157420d8a
😎 Deploy Preview https://deploy-preview-1015--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Each image now owns its segment definitions, order and selection. A new
image copies the previous image definitions once, and a restored set or
companion segmentation replaces a copy nobody has edited yet.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant