Repository navigation
Issue #226: atomically consume history-preview consent under concurrent requests - #237
Merged
Merged
Conversation
This was referenced Oct 15, 2026
KAVentures
added a commit
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Historical evidence backfill is OFF by default, but its merged preview/confirm path previously verified the token and deleted the token/digest/window/expiry as separate SQLite writes. Two simultaneous authenticated confirmations could both pass validation and send the same historical evidence; an in-flight preview could also interleave with the field deletion.
Change
SyncState.consume_if_matchesprimitive. SQLiteDELETE ... WHERE value = ?succeeds exactly once across threads/processes and removes companion keys in the same transaction.Required acceptance
Run Python tests, Windows/macOS/Linux packages and privacy regressions. Leave
OWG_ENABLE_HISTORY_BACKFILLOFF pending the full real Gateway/privacy/migration review; this PR does not enable historical uploads or close #226. Please do not auto-merge.