Repository navigation
Issue #226: permanently withhold Discovery Mode studies from historical sync - #239
Merged
KAVentures merged 1 commit intoOct 16, 2026
Merged
Conversation
KAVentures
force-pushed
the
fix/issue226-discovery-history-permanent-exclusion
branch
from
October 16, 2026 10:32
5e1d92c to
4e5972d
Compare
KAVentures
added a commit
that referenced
this pull request
Oct 16, 2026
KAVentures
added a commit
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Privacy failure mode
PR #233's historical consent gate remains OFF, but
connector/history_backfill.pyexcluded Discovery events by ID only while the study was stillenabled. On deactivation, a user who had never connected an organization Gateway had no ordinary paused-sync skip range, so later enrollment + a separately confirmed backfill could include captured Discovery Mode evidence—contradicting the study's separately reviewed sharing promise.Corrections
No change to default OFF (
OWG_ENABLE_HISTORY_BACKFILL), source connectors, Gateway APIs, explicit study-package sharing or forward cursor. Do not enable backfill from this PR alone—seeded Gateway privacy/migration/rollback acceptance (#236) and remaining rollout requirements still apply.Run full Windows/macOS/Linux CI before merge; real signed Mac + Gateway acceptance is still required.
CI isolation fix (2026-10-16): Old main API tests on all 3 OSes unexpectedly received 401 after the new Discovery-mode test imported
server.discovery_routesinto the shared pytest process. That module transitively importsserver.secure_app, registering its authorization middleware onserver.main.app. The test now performs this route import and skip-range assertion in an isolated, temporary-data subprocess instead of polluting unrelated tests. Auth middleware is unchanged; no security guards are disabled. Commit5e1d92c1triggers full CI rerun. Do not merge until the entire latest matrix is green.Conflict resolution after #235/#238/#237 merged (2026-10-16): Replayed the six #239 files onto fresh
main(f0fd4308) with a force-with-lease update to4e5972d6. In the three overlapping history/consent files, manually integrated the Discovery Mode exclusions and tests while retaining #237'sSyncState.consume_if_matchesatomic single-use consent, its expiry recheck, concurrent confirmation regression tests, and the corresponding documentation. The other three #239 files match their original PR blobs. GitHub now reportsmergeable=trueand the PR diff is restricted to the intended six files. The new Actions jobs must pass before merge; historical sync remains off by default.