debug: correct d0 at k+1 for MovingHorizonEstimator with collocations - #452
Merged
Merged
Conversation
franckgaga
marked this pull request as ready for review
September 20, 2026 17:10
d0 value at k+1 for MovingHorizonEstimator with collocationsd0 at k+1 for MovingHorizonEstimator with collocations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 28 28
Lines 6811 6812 +1
=======================================
+ Hits 6622 6623 +1
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug affects the$\mathbf{d_0}$ at the end of the windows.
MovingHorizonEstimatorwithTrapezoidalCollocationandOrthogonalCollocationtranscriptions. It was using the wrong measured disturbances valueThe next measured disturbance$\mathbf{d_0}(k+1)$ is not available for the MHE, and the prediction form ($\mathbf{d_0}(k+1) \approx \mathbf{d_0}(k)$ .
direct==false) requires it at the end of the windows with the collocation methods (since piecewise linear measured disturbances is assumed, disregard of thehargument). This PR implement the correct logic in theforloop for the approximation