Repository navigation
fix(corekit): zero-fill a cut list of schema items to its length (#2686) - #2701
Merged
Merged
Conversation
A list of schema items the capture cut short now reads its items zero-filled to the declared length, as FieldBase.unpack reads any other field, so the per-protocol pieces built around it go. - ListField.unpack zero-fills a short buffer of schema items through _zero_fill_items: refused past MAX_ZERO_PAD_LENGTH, charged to the running budget with no free band or one-off allowance, and the zeros earn none. - Removed SettingPairListField, GroupRecordListField, HTTPv2.make's frame_length, its _make_data pass-through and _made_length, so from_data on an edited HTTP/2 frame recomputes its Length again. - Report.post_process keeps the records it trims from the parsed list and moves a short read past them onto payload, so an IGMPv3 schema cut inside its Additional Data packs back as captured. - A cut SACK option is now refused by OptionField's run-past-the-data check. Every tests/ module passes; sample captures parse identically to main. Closes #2686 Closes #2687
JarryShaw
added
bug
JarryShaw
added
review: good-to-go
Owner
Author
|
GOOD TO GO at
Two small follow-ups go into this PR, and I'll verify the amend: restore the up-front ledger debit if an item fails after the fill, and shorten the |
JarryShaw
removed
the
review: good-to-go
This was referenced Nov 2, 2026
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…s, the cut schema lists, the TSO checksum cut and short ZigBee keys into 1.6.0 (#2449) - Breaking: MH (#2700) refuses a mobility option, or a sub-option, QoS attribute or CGA extension of one, whose fields do not take its length, where 1.5.x rebuilt another; QualityOfServiceOption gains a required tc_reserved. Prefix lengths are held to their field's width, the NAI and service identifier makers count octets, and a long-form DER CGA key parses. Folded into the MH/DSS and makers' range-check entries, with a QoS entry of its own; old and new values measured against v1.5.1. - Fixed: ListField zero-fills a cut list of schema items, bounded by ZERO_PAD_BUDGET_RATIO with no free band, and a SACK past the data raises ProtocolError where it raised FieldValueError (#2701); a Decryption Secrets Block made from a short parsed ZigBee key is written as captured, and zigbee_key_held's schema holds the octets given (#2697). - Folded into unreleased entries: radiotap's mixed bitmaps, their known-bits registries and BitmapField (#2696), into the Radiotap entry; the TSO and AH checksum cut (#2699), into the checksum and contextvars entries; the zero-filled SETTINGS and IGMPv3 records and the IGMPv3 Additional Data rebuild (#2701), into the HTTP/2 SETTINGS and IGMP entries, dropping HTTPv2.make's unreleased frame_length. - No entry for the docstring-and-test-only be83061 (#2695). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Regression from #2666, unreleased:
from_data(info.to_dict())on an edited whole HTTP/2 frame now recomputes the Length again, where it wrote a stale one or raised.A cut list of schema items now zero-fills in core.
ListField.unpackpads a short buffer to the declared length once, through_zero_fill_items. Like every other field, the fill counts against the zero-pad budget, and it is refused pastMAX_ZERO_PAD_LENGTH. A cut list then reads the way DATA's zero-filled bytes do: settings past the data read as(Reserved_0x0000, 0), records as zero records. Both shapes are pinned. This removesSettingPairListField,GroupRecordListField,HTTPv2.make(frame_length=)and the_made_lengthside channel; none of them shipped.IGMPv3 (#2687):
Report.post_processtrims the parsed record list and moves the built-in short-read record topayloadwhen the cut is past the kept records. A schema-level rebuild therefore keeps the Additional Data octets.The cut sweeps, the edited-frame round trips and the schema-level IGMPv3 tests all fail on
main. Every test module passes, and sample captures parse identically.Closes #2686
Closes #2687