Repository navigation
fix(corekit): a failed list zero-fill leaves its ledger debit behind #2705
Description
Left over from #2701's review, after it merged before the follow-up landed. In pcapkit.corekit.fields.field, _zero_fill_items debits the zero-pad ledger up front (ledger[0] -= padding) and never restores it if an item fails after the fill.
Measured on a synthetic schema whose item raises after the fill: one failure took ledger[0] from 1000 to -997, and every later legitimate cut in that context was refused. The ledger is context-wide.
Fix: restore the debit on failure (try/finally), and add a test that a failed fill leaves the ledger as it was. Also trim the four-line # NOTE: in HTTPv2._make_data to the two-line limit.
Activity
JarryShaw commentedon Nov 2, 2026
The fix is ready at
8ab90dfdb. Its PR is held because the Actions queue is at 50; new PRs wait for fewer than 20. A Sonnet review is running on the local commit in the meantime.JarryShaw commentedon Nov 2, 2026
The PR is #2706.