Repository navigation
ci(conda): publish the win-64 package (#2060) - #2138
Merged
Merged
Conversation
Owner
Author
|
GOOD TO GO at
|
Phase 2 of #2060: Conda Update's runs built and smoke-tested win-64 green, so both conda jobs now publish it from a blocking Windows leg. - cron-conda.yml: the Windows leg loses its `continue-on-error` guards and `Windows summary`, and uploads through the new "Upload conda packages to Anaconda (Windows)": the Intel leg's anaconda-client call under `bash -el`, skipped on a manual run as every upload is. - create-release.yml: `conda` gains the `windows-latest` leg, with `shell: bash` on its `run:` steps, a login shell for conda, setup-python's `python.exe` in the smoke test, and the same upload, gated on `check_leg`. The GitHub Release still takes linux-64 alone. - release_published.py: SUBDIRS counts win-64, and a tagged version is counted for the SUBDIRS its tag's commit lists, so one released before win-64 does not read as unfinished. - release_conda.py: `upload` runs base's `Scripts\anaconda.exe` on Windows. - leg_summary.py: the `conda-windows` tier goes. test_conda_windows_leg_2060 and test_release_tags_the_run_sha_1634 pin the upload, the blocking leg and the released platforms; the tests reading the conda jobs, platforms and counts follow, as do the docs.
JarryShaw
force-pushed
the
ci/2060-publish-win64
branch
from
October 24, 2026 05:00
214d266 to
b602422
Compare
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
This closes #2060 (phase 2). |
4 of 5 tasks
This was referenced Oct 24, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
Phase 2 of #2060: publish the win-64 conda package. Phase 1 passed on
main(run 40052211743): everywindows-latestleg, 3.11–3.15, green with no warnings.Conda Update
conda-dist: the Windows legs uploadwin-64withanaconda-client, like the Intel legs (ci(conda): upload the macos-26-intel legs with the anaconda CLI (#2044) #2049). The new step is "Upload conda packages to Anaconda (Windows)", run in abash -ellogin shell. The build-only dispatch guard still skips it, andtest_build_only_dispatchtreats the upload as a publishing marker.Create Release
conda: gains awindows-latestleg with the same upload, gated oncheck_leglike the others.util/release_published.py:SUBDIRS(PCAPKIT_CONDA_SUBDIRS) addswin-64, so a release counts as complete only once win-64 is on Anaconda.util/release_conda.py:uploadresolvesScripts\anaconda.exeon Windows.The Windows leg now blocks like the other platforms. Its
continue-on-error,Windows summarystep andconda-windowssummary tier are removed.Unchanged: no new secrets or environments; it uses the existing
ANACONDA_TOKENinanaconda. The GitHub Release upload is unchanged; onlyubuntu-latestdoes that.Tests:
test_conda_windows_leg_2060.pyis reworked, and the pins in the other conda/release tests are updated. Without the change, 28 of 56 tests fail. A 68-file selection of the workflow-reading tests gives 1224 passed. actionlint 1.7.12 is clean.Unverified until a real run:
win-64inSUBDIRS, the current published version reads as incomplete. Thecondajob still skips it whilePCAPKIT_RELEASED_ELSEWHEREis true, so win-64 first ships with the next release.Completeness (round 2): a version counts as complete against the platforms its tagged commit published (
release_published.released_subdirs(), readingSUBDIRSat the tag). So 1.5.0b14 is not newly flagged forwin-64. It is still flagged for its missingosx-64files, which predates this PR: release: 1.5.0b14 has no osx-64 conda files, so Create Release warns it is unfinished on every released-elsewhere run #2140.A first real release exercises: on
create-release.yml'swindows-latestconda leg, the pre-setup-python stepsCheck the release tags name this run's commitandCheck whether this leg is already on Anaconda(python3under Git Bash,/tmpmapping,curl), thenUpload conda packages to Anaconda (Windows)in both jobs. The first scheduled Conda Update after merge exercises the upload; a build-only dispatch does not.