Repository navigation
ci(lint): clear the advisory linters' long-standing false positives (#2145) - #2147
Merged
Merged
Conversation
…2145) - vermin: drop `--no-parse-comments`, so the `# novermin` markers on the version-gated backports in `compat.py` count; spell the builtin generics in `TYPE_CHECKING` aliases (`RawFrame`, `Packet`, `CallbackFn`, `_ContextManager.__exit__`) with `typing.Tuple`/`List`/`Type`. vermin now meets the 3.8 target. - bandit: `# nosec: B104` on the MH IPv4 option builders' `0.0.0.0` defaults, justified `# nosec` on the intentional `continue`s (B112) and the escape-only `xml.sax.saxutils` import (B406); stop a comment in the TLS key label crawler from reading as a B105 marker. bandit is clean. - mypy: delete the unused `type: ignore`s (and the unused codes of partly used ones, generator templates included); wrap pyshark's two link-type tables in `cast()`, as mypy reads aenum members as `int`, and make `util/pyshark_encap_map.py` render that shape. Neither vermin nor bandit is promoted to blocking here.
JarryShaw
added
ci
Owner
Author
|
GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
This closes #2145. Promoting vermin and bandit to blocking in |
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
Closes #2145. Comments, annotations and lint flags only; there is no behaviour change.
make vermin)make bandit)make mypy)--no-parse-commentsis dropped. It came with the first vermin recipe in 2022, before the# noverminmarkers existed, and it made vermin ignore them. TheTYPE_CHECKING-only builtin generics now useTuple/List/Type.# nosec: B104 # not a bindon theMH0.0.0.0packet defaults, and justifiednosecon the two intentionalcontinues and the escape-onlyxml.sax.saxutilsimport. A comment that bandit read as a marker is reworded.pcapkit/vendorgenerator templates, so a regeneration keeps them out. The pyshark link-type tables are wrapped incast, andutil/pyshark_encap_map.pynow emits that form, reproducing both committed tables exactly.continue-on-error). Making them blocking is the owner's call.lint.yml, theMakefileor the generator, plus isort, issue-refs and the tier guard, give 357 passed. Narrow unit selections over every touched area give 2826 passed.