Repository navigation
ci: copy the superseded watcher's summary lines into the job-summary artifact (#2078) - #2080
Conversation
|
GOOD TO GO at
|
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
|
Ready to merge at |
…mmary (#2078) A stopped experimental leg's only job-summary line came from util/superseded.py, which wrote $GITHUB_STEP_SUMMARY alone, so job-summary.md was never created and `Upload the job summary` found no file (run 39898485708). `watch` now takes `--summary-copy PATH`, which `Run unit tests` passes, and appends both of its summary lines there too. It is an option rather than JOB_SUMMARY_COPY so the tests the watcher runs never inherit the copy's path.
|
Rebased onto
The diff changed, so a delta review is running. |
0e31e04 to
53bcc80
Compare
|
GOOD TO GO at
|
|
Ready to merge at |
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Closes #2078. The #2071 copy plumbing works. Run 39898485708 simply had nothing to copy.
- Superseded: …, goes to$GITHUB_STEP_SUMMARYalone. That was a deliberate choice, so the test step never seesJOB_SUMMARY_COPY. Containment summary and Experimental summary wrote nothing on that clean path.job-summary-test-4andjob-summary-engine-tests-*.The fix:
superseded.py watchgains--summary-copy PATH. Its two summary lines go to the job summary and then to that file.--summary-copy "$RUNNER_TEMP/job-summary.md"to the watcher only, so the tests still never see the variable.experimental.yml, the sentence inworkflows.rstand the_actionsdocstring are updated.Tests:
test_superseded_summary_copy_2078runs the real Run unit tests and Name the job summary scripts. It then reads the files at the upload step's ownpath:, and checks that the tests never seeJOB_SUMMARY_COPY. Onmain, 6 of its 9 tests fail. The superseded, reporter, KTLO-guard, matrix-tier and timing tests pass.Overlap: #2079 moves
superseded.py's summary writes onto_actions.summary, so whichever merges second needs a rebase. This merges cleanly with #2076.