Skip to content

ci: say a superseded Experimental leg was stopped, not that its tests exited 0 (#2077) - #2088

Merged
JarryShaw merged 1 commit into
mainfrom
ci/2077-containment-superseded
Oct 23, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/2077-containment-superseded

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • ci — changes to CI configuration files and scripts

Description of your pull request and other information

Closes #2077. When the watcher stops an Experimental leg as superseded, Containment summary now says tests were stopped as superseded after N s instead of tests exited 0, which read as a pass.

… exited 0 (#2077)

util/superseded.py's watch exits 0 when it stops a superseded run, so
Containment summary closed on 'tests exited 0 after 61 s'. It now reads
the tests step's stopped output through env and says the tests were
stopped as superseded, with no warning of its own; every other line and
warning is unchanged.
@JarryShaw JarryShaw added bug Issues reporting a defect (set by the bug report template; a default, not an assessment) ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 23, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 6a82fae3a (Sonnet cross-review).

  • Workflow diff: a YAML diff shows only the Containment summary step's new STOPPED env key and its run: body changed.
  • The output reaches the step: Run unit tests has id: tests and continue-on-error, and Containment summary runs later in the same job under !cancelled(). So the output is readable even after a failure. When there was no stop, $STOPPED is empty and the summary still says exited ${code}.
  • Real problems still warn: every warning (No memory cap, OOM kill, timeout, MemoryError, xdist worker) is raised before the new if and still uses $code. A test pins that the warnings are identical whether the run was stopped or not.
  • The tests: with main's experimental.yml swapped in, the new test's stopped-run and env checks fail. Shellcheck and actionlint pass.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 23, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 91.54% (unit tier, Python 3.15, 6a82fae3a, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 19599 880 2618 866 92.12%
pcapkit/corekit 2565 71 812 37 96.56%
pcapkit/dumpkit 282 3 102 3 98.44%
pcapkit/foundation 2930 23 1022 25 98.79%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 17414 219 4574 185 98.14%
pcapkit/toolkit 869 36 298 10 95.20%
pcapkit/utilities 473 7 136 5 98.03%
pcapkit/vendor 4432 1988 1018 167 51.87%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw

Copy link
Copy Markdown
Owner Author

Ready to merge at 6a82fae3a. The review is GOOD TO GO, CI is complete (56 passed, 0 failed), the ordering leg ran 2058 tests with 0 failures, and the 3.8–3.10 KTLO legs show 0 failing tests. The branch is behind main by #2079, #2086 and 26f1a72. I merged it into current main (26f1a72ef) in a scratch tree, and the Containment summary, superseded, resource-monitor, shellcheck, KTLO-guard and actionlint tests all pass there.

@JarryShaw
JarryShaw merged commit e416eb9 into main Oct 23, 2026
65 checks passed
@JarryShaw
JarryShaw deleted the ci/2077-containment-superseded branch October 23, 2026 14:41
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 23, 2026
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issues reporting a defect (set by the bug report template; a default, not an assessment) ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ci: Containment summary reports a superseded stop as 'tests exited 0'

1 participant