Repository navigation
ci: say a superseded Experimental leg was stopped, not that its tests exited 0 (#2077) - #2088
Merged
Merged
Conversation
… exited 0 (#2077) util/superseded.py's watch exits 0 when it stops a superseded run, so Containment summary closed on 'tests exited 0 after 61 s'. It now reads the tests step's stopped output through env and says the tests were stopped as superseded, with no warning of its own; every other line and warning is unchanged.
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— changes to CI configuration files and scriptsDescription of your pull request and other information
Closes #2077. When the watcher stops an Experimental leg as superseded, Containment summary now says
tests were stopped as superseded after N sinstead oftests exited 0, which read as a pass.STOPPED: ${{ steps.tests.outputs.stopped }}(from ci: stop warning about missing JUnit on legs stopped as superseded (#2073) #2076) throughenv:, never insiderun:, and only the closing line changes.Supersedednotice already explains the stop.0 worker(s) downand no warnings, so there was nothing else to suppress.workflows.rstgets one sentence on it.test_superseded_containment_summary_2077runs the real Containment summary script for a stopped run and a normal run. It also runs it after the real Run unit tests step, once stopped and once on a current commit. Onmainit gives 6 failed.test_resource_monitor_1740's env pin now includesSTOPPED.