Repository navigation
ci: install through util/pip_install.py in experimental and Compat (#1967) - #2032
Merged
Merged
Conversation
JarryShaw
added
ci
JarryShaw
force-pushed
the
ci/1967-step2-pip-install-rest
branch
from
October 22, 2026 03:11
7633a68 to
4bd0be4
Compare
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
4 of 5 tasks
JarryShaw
force-pushed
the
ci/1967-step2-pip-install-rest
branch
from
October 22, 2026 03:46
4bd0be4 to
9b5ce1e
Compare
Owner
Author
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
4 of 5 tasks
Owner
Author
|
resolve conflicts |
…1967) - experimental.yml: the experimental job's install step runs the script in place of its inline shell; same extras, id, if, continue-on-error, timeout, shell and LEG, at the job's warning level. - python-compatibility.yml: Compat's install step runs the script, with LEG on the step, so a failed install now writes the job's ANNOTATION_LEVEL annotation; id, if, continue-on-error unchanged. - tests: test_pip_install_1967.py pins both steps whole, their jobs' levels, and every other pip install in those workflows; the 1633 install tests run Compat's step too, under the default shell. - workflows.rst: the script's callers include both jobs.
JarryShaw
force-pushed
the
ci/1967-step2-pip-install-rest
branch
from
October 22, 2026 14:49
9b5ce1e to
56579c6
Compare
Owner
Author
|
Rebased onto |
4 of 5 tasks
JarryShaw
removed
the
review: good-to-go
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
#1967 step 2, the rest of item 3. Stacked on #2031, so review only the top commit.
experimental.ymlexperimental: its inline install-and-annotate shell becomespython util/pip_install.py -e '.[test,DPKT,crypto,NGAP]'. The behaviour is the same.python-compatibility.ymlcompatibility: the bareInstall packagestep becomespython util/pip_install.py -e ., with aLEGenv. A failed install now annotates (warningon KTLO legs,erroron supported ones) and exits 1.test_pip_install_1967pins both sites. The 1633 KTLO tests now run Compat's step for real, on a clean install and on a failed one.The pin fails on #2031's workflows (
3 failed) and passes here (21 passed). Every test file that reads either workflow gives523 passed. With a stand-in pip, the script ran correctly on 3.7.16, 3.8.20, 3.14.8 and 3.14.8t. GraalPy and 3.15 are not installed locally.