Repository navigation
fix(ci): read pip's indented ERROR line in util/pip_install.py (#2041) - #2042
Merged
Merged
Conversation
- reason() strips each line's leading whitespace before matching the `ERROR: ` prefix, so a failed wheel build's indented ` ERROR: Failed building wheel for ...` names the annotation instead of the no-ERROR-line fallback - tests: a fixture from the pypy3.10 (KTLO) failure log, its exact annotation, and the parity case where the former shell's `^ERROR: ` now diverges on purpose
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ordering check on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Closes #2041.
reason()inutil/pip_install.pyonly matched lines that start withERROR:. When pip fails a wheel build it indents that line (ERROR: Failed building wheel for cryptography), so the annotation fell back to "pip failed without an ERROR line".reason()now strips each line's indent before matching and still takes the last match. Pip's closingFailed to build …anderror: failed-wheel-build-for-installlines carry noERROR:prefix and say less.Failed building wheel for cryptography. The rest of this leg is skipped.ERROR:cases. A second test pins the deliberate departure from the old inline shell, which had the same gap.The new tests fail without the fix (
3 failed, 18 passed) and pass with it (19 passed). Withtest_python_matrix_tiers_1633:45 passed.experimental.yml's inline copy of the old sed has the same gap; #2032 replaces it with this script.