Repository navigation
ci: install through util/pip_install.py (#1967) - #2031
Merged
Merged
Conversation
JarryShaw
added
ci
This was referenced Oct 22, 2026
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
- util/pip_install.py: upgrades pip, setuptools and wheel, then installs the given editable spec, teeing its merged output to $RUNNER_TEMP/pip-install.log; a failed install writes the same ANNOTATION_LEVEL annotation naming pip's last ERROR line and exits 1. Standard library only, 3.7-compatible. - unit-tests.yml: the install step of test, integration, pypcap-parity, unittest-ordering, project-tests and gate runs the script. The last four gain the annotation; the latest-only jobs set ANNOTATION_LEVEL: error and LEG on the step, pypcap-parity sets LEG. id, if, continue-on-error and shell are unchanged. - tests/_dependency_gates.py: EDITABLE_INSTALL, the shared extras pattern for both install forms, used by every reader of install lines. - tests: test_pip_install_1967.py covers the script, its parity with the former shell, and pins every site; the 1633 install tests stub pip instead of python; the tier-guard doctorings use the new form. - workflows.rst: the script joins the Workflow Scripts table.
JarryShaw
force-pushed
the
ci/1967-step2-pip-install
branch
from
October 22, 2026 03:46
7c5f371 to
0fac0e4
Compare
Owner
Author
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ordering check on |
This was referenced Oct 22, 2026
4 of 5 tasks
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
#1967 step 2, item 3. #2027 and #2029 have landed, so this is one commit on
main.util/pip_install.pyupgrades pip, setuptools and wheel, then runs the editable install, logging to$RUNNER_TEMP/pip-install.log. On failure it writes the install-failure annotation. Sixunit-tests.ymlsteps call it:test,integration,pypcap-parity(all three with their KTLO twins),unittest-ordering,project-testsandgate.tests/_dependency_gates.pygainsEDITABLE_INSTALL, which matches both forms, and its readers use it.Install coverage, andengine-tests's per-cell venvs.experimental.ymlandpython-compatibility.ymlfollow in their own PR.The pin fails on #2029's
unit-tests.yml(11 failed) and passes here. A parity test checks the old shell against the script on a stand-in pip, for seven outcomes at both annotation levels. The 40 test files that readunit-tests.ymlor_dependency_gates.pygive716 passed, 4 skipped.