Repository navigation
ci: regenerate sample captures through util/regenerate_samples.py (#1967) - #2029
Merged
Merged
Conversation
JarryShaw
added
ci
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
Owner
Author
|
resolve conflicts |
- releasing.rst, workflows.rst: replace every `unit-tests.yml:N` citation with the job, step `name:`, or comment it pointed at. - TestWorkflowsCitedByName: add `unit-tests.yml` to `BY_NAME`, so a line citation of it, or a bare `:N` beside it, fails. - Drop `CITATIONS` and `TestDocCitationsResolve`, the line anchors the by-name rule replaces.
) - util/regenerate_samples.py: runs examples/generators/make_samples.py, tees its merged output to $RUNNER_TEMP/make-samples.log, and writes the same fixture-failure annotation at ANNOTATION_LEVEL, the same degraded warning with the marked lines, or the same upstream line as the shell did. - unit-tests.yml: `Regenerate sample captures` in integration, pypcap-parity and gate runs the script; gate passes ANNOTATION_LEVEL: error on the step, keeping its level. id, if, continue-on-error and shell: bash are unchanged. - tests/project/test_regenerate_samples_1967.py: the script's outcomes and failure paths, a parity run against the former shell, and a pin that every site calls the script and no workflow keeps the inline shell. - workflows.rst: the script joins the Workflow Scripts table.
JarryShaw
force-pushed
the
ci/1967-step2-regenerate-samples
branch
from
October 22, 2026 02:42
328b096 to
87dd51d
Compare
Owner
Author
4 of 5 tasks
Contributor
|
Coverage: 91.54% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
JarryShaw
removed
the
review: good-to-go
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
#1967 step 2, item 2. Stacked on #2027, so review only the second commit.
util/regenerate_samples.pyreplaces the inline shell in theRegenerate sample capturesstep ofintegration,pypcap-parityandgate. It runsmake_samples.py, tees its output to$RUNNER_TEMP/make-samples.log, and writes the same fixture-failure annotation, degraded-capture warning and upstream line as before. It uses only the standard library.gateused a literal::error. It now setsANNOTATION_LEVEL: erroron the step, so every caller states its level.workflows.rstlists the script under Workflow Scripts.The new pin fails on #2027's
unit-tests.yml(5 failed) and passes here (12 passed). A parity test runs the old inline shell and the new script against the same stand-in generators and requires identical stdout, exit status and log. The test files that readunit-tests.ymlgive792 passed.Two differences, both on a misconfigured runner only: an unset
RUNNER_TEMPnow fails with a traceback rather than throughtee, and an unknownANNOTATION_LEVELexits 2.