[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Description of your pull request and other information

Closes #1599.

Renames pcapkit.utilities.warnings.hold_warnings (#1588, unreleased) to HoldWarnings and drops its # pylint: disable=invalid-name. No alias, since it has never shipped. Touched: pcapkit/utilities/warnings.py, its one caller pcapkit/protocols/protocol.py, docs/source/pcapkit/utilities/{functools,warnings}.rst, and #1588's test file.

HoldWarnings is documented by autoclass and imported from another module, so it is public. It is now listed in pcapkit.utilities.warnings.__all__, beside warn. It was missing there on main too. pcapkit.utilities imports only warn, so neither pcapkit nor pcapkit.all changes.

The pcapkit_held_warnings ContextVar and the test's _HoldNothing stand-in keep their names: neither embeds the class name.

New test test_hold_class_is_named_in_camel_case asserts HoldWarnings imports and is in __all__, and that neither pcapkit.utilities.warnings nor pcapkit.protocols.protocol has hold_warnings. It fails in three cases:

• on main: ImportError: cannot import name 'HoldWarnings'
• with a hold_warnings = HoldWarnings alias added: AssertionError: True is not false
• without the __all__ entry: AssertionError: 'HoldWarnings' not found in ['warn', 'BaseWarning', ...]

Lint: pylint pcapkit/utilities/warnings.py gives 10.00/10 without the disable. On main's copy with the disable removed, it reports C0103: Class name "hold_warnings" doesn't conform to PascalCase naming style. isort is clean. mypy reports nothing in warnings.py.

Tests: I ran narrow selections only. They covered #1588's file, tests/protocols/test_protocol_*_unit.py, tests/test_docstring_contract.py, and the tests/project docs and public-API checks. All passed.

[JarryShaw]

Closing unmerged: the owner chose on #1599 to keep the lowercase name. The __all__ export this PR also added moves to #1602, against hold_warnings.