Repository navigation
refactor(utilities): rename hold_warnings to HoldWarnings #1599
Description
pcapkit.utilities.warnings.hold_warnings (added in #1588) is a class with a lowercase name. It is the only lowercase class pcapkit defines itself; the other, cached_property at pcapkit/utilities/compat.py:75, is a verbatim stdlib backport. It also needs # pylint: disable=invalid-name at pcapkit/utilities/warnings.py:217. The owner queried the name on #1588.
Change: rename it to HoldWarnings everywhere and drop the pylint disable. It is unreleased (1.5.0 has not shipped), so no alias is needed. References on main (589414eba):
pcapkit/utilities/warnings.pypcapkit/protocols/protocol.py:53and:2322docs/source/pcapkit/utilities/functools.rst:46docs/source/pcapkit/utilities/warnings.rst:33- fix(protocols): drop the warnings of a next layer replaced by Raw (#1580) #1588's test file
Keep the ContextVar name unless it also embeds the class name.
Activity
JarryShaw commentedon Oct 10, 2026
Okay since it's matching it's Stalin counterpart, i say we keep the lower case snake name
refactor(utilities): rename hold_warnings to HoldWarnings (#1599)
JarryShaw commentedon Oct 10, 2026
Recorded: the owner prefers to keep the lowercase
hold_warnings, because it mirrors its stdlib counterpartwarnings.catch_warnings. The rename is dropped, #1601 is closed unmerged, and theinvalid-namedisable stays.The #1601 review found one gap that does not depend on the name: the class is public (documented by
autoclassand imported bypcapkit/protocols/protocol.py) but missing frompcapkit.utilities.warnings.__all__, which listswarnand every warning class. The stdlib exportscatch_warningsthe same way, so I've filed #1602 to add'hold_warnings'to__all__.