Repository navigation
fix(protocols)!: rename OSPF_CrytographicAuthentication and group OSPF under the application layer - #1116
Merged
Conversation
…F under the application layer - Rename the misspelled OSPF schema and data classes to CryptographicAuthentication, exported as OSPF_CryptographicAuthentication. No alias keeps the old name: this is a breaking rename. - Move both OSPF names into the application-layer group of the pcapkit.protocols.schema and pcapkit.protocols.data __all__ lists, and drop the inline "# application layer" comment. - Move the OSPF auth-data selector assertions out of the link tests into tests/protocols/application/. Closes #1090
JarryShaw
added
breaking
Owner
Author
|
Cross-review verdict on
Pre-existing, outside this PR: |
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 88.74% (unit tier, Python 3.14,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Oct 6, 2026
- 22 new 1.5.0 entries for the 30 PRs merged since b10e795 (#1106-#1158), with related fixes grouped per the #918 ruling; three marked breaking to match their labels (#1116, #1138, #1145) - regenerate CHANGELOG.md with util/changelog_md.py - process.rst: entry-count pin re-measured, 167 -> 189 - pep.rst: note the plist round-trip test skipped on the upstream dictdumper fractional-second <date> defect (DictDumper#122) tests/project: conventions_doc_claims, changelog_md and documentation_claims pass; changelog_md.py --check is in step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort) — run on the touchedpcapkit/files with the Makefile flags; no new findings (3 mypy errors inapplication/ospf.pypredate this PR)make testpasses, and a test case covers the change — the modules listed below, not the full suitedocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A, added centrally after the waveWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
Closes #1090. Breaking:
OSPF_CrytographicAuthentication(andCrytographicAuthenticationin bothospfmodules) becomesOSPF_CryptographicAuthentication/CryptographicAuthentication. No alias keeps the old name. Both OSPF names move to the application group ofschema.__all__anddata.__all__.Probe (
schema/data): before, new nameFalse, oldTrue, OSPF listed betweenL2TP/EthernetandVLAN. After, newTrue, oldFalse, OSPF listed afterNGAP.New
tests/protocols/application/test_ospf_cryptographic_authentication_unit.py: without the fix,11 failed, 3 passed(all 4 tests fail). With it,4 passed, 10 subtests passed. Also passing:test_ospf_unit(3),link/test_link_unit(24),test_layer_placement_unit(17),project/test_public_api(10), andtests/project(379 passed, 1 skipped).