Repository navigation
Show issue titles in Waterfall run choices - #1421
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1412.
Waterfall choices and the selected Runs line show the retained issue title. Long titles use an ellipsis with the full title on hover; records without titles keep their labels.
Evidence
cargo test --test console waterfall_choices_name_issues_and_keep_untitled_commands_selectablefailed because the Runs summary omitted the title. The browser regression failed because long titles were not clipped.After: the regression and all 7 focused Rust Waterfall tests pass.
node --test console/tests/waterfall.test.cjs console/tests/spans.test.cjspasses all 8 tests at desktop and 390 px, including title selection, escaping, clipping and live refresh.main: Standards 0 findings; Spec 0 findings./usr/bin/time -p scripts/affected-tests mainselected the full Rust suite (cargo test, nextest unavailable): passed in 1480.33 seconds wall time, including compilation.cargo fmt --checkandcargo clippy --all-targets -- -D warningspassed.d7282531, including Linux, the macOS gate, Console and site browser tests, and release builds.Merge Danger
Door: two-way
Blast Radius: Console
Display-only use of existing retained titles; no record format changes or new GitHub reads.
Unaddressed findings
Standards
None; the reviewer raised 0 findings.
Spec
None; the reviewer raised 0 findings.
Security
None; the reviewer raised 0 findings.
Security review outcome
No unaddressed introduced findings.
Review coverage
Both axes read all six changed files. Unread changed files: none. Generated-output exclusions: none.
Testing seams
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh