Repository navigation
Show the issue and title first in Command details - #1419
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command details opens with the same subject and full issue title as its Inbox row, above Stop and Dismiss. The subject links to the issue; long titles wrap.
The shared Inbox rules also cover missing titles and Commands without an issue. The details JSON already contains recorded titles; regression coverage now checks CLI/Console agreement. Console documentation and all three hand-written site pages describe the heading.
Closes #1408
Evidence
cargo test --bin thirdshift console::peek::tests::command_heading_precedes_stop_and_dismissfailed because the heading wasCommand details.After: the same test passes, checking the linked subject, escaped title, accessible name, and ordering before Stop/Dismiss.
cargo test --test console command_details: 4 passed, including title/subject fallbacks matching the Inbox.cargo test --test console peek_and_full_logs_use_the_exact_selected_command_and_share_show_details: passed, including the selected Command's recorded title in bothshow --jsonand the pane heading.node --test console/tests/inbox.test.cjs: 52 passed, including full title wrapping at 1280px and 390px.cargo check: passed./usr/bin/time -p scripts/affected-tests main: passed, including all 51 site browser tests and the full Rust suite (cargo test; nextest unavailable). Wall time: 1462.07s (24m22s), including compilation; the Rust build phase was 44.34s, with dependencies already built by focused tests.Test seams
Peek::newand its rendered HTML from Command details JSON./peekresponse and Inbox rows from retained Command records.thirdshift show <command> --jsonfrom retained Command records.Review
Independent reviews against
main: Standards 0 findings; Spec 0 findings. Both axes read all 11 changed files and their supporting context. No generated-output exclusions. Unread changed files: none on either axis. Reports andsummary.jsonare saved under.thirdshift-review-dhYFuJ/for the Session trace.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reverting restores the previous heading; no stored records or JSON schema change.
Blast Radius: Console
Command details heading and shared presentation visibility, with matching documentation and regression tests.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh