Skip to content

Show the issue and title first in Command details - #1419

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-1408
Oct 27, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-1408

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Command details opens with the same subject and full issue title as its Inbox row, above Stop and Dismiss. The subject links to the issue; long titles wrap.

Command details (accessible region)
  acme/widgets#7 → issue
  Full issue title
  Stop / Dismiss
  Recorded facts and logs

The shared Inbox rules also cover missing titles and Commands without an issue. The details JSON already contains recorded titles; regression coverage now checks CLI/Console agreement. Console documentation and all three hand-written site pages describe the heading.

Closes #1408

Evidence

  • Before: cargo test --bin thirdshift console::peek::tests::command_heading_precedes_stop_and_dismiss failed because the heading was Command details.
    After: the same test passes, checking the linked subject, escaped title, accessible name, and ordering before Stop/Dismiss.
  • cargo test --test console command_details: 4 passed, including title/subject fallbacks matching the Inbox.
  • cargo test --test console peek_and_full_logs_use_the_exact_selected_command_and_share_show_details: passed, including the selected Command's recorded title in both show --json and the pane heading.
  • node --test console/tests/inbox.test.cjs: 52 passed, including full title wrapping at 1280px and 390px.
  • cargo check: passed.
  • /usr/bin/time -p scripts/affected-tests main: passed, including all 51 site browser tests and the full Rust suite (cargo test; nextest unavailable). Wall time: 1462.07s (24m22s), including compilation; the Rust build phase was 44.34s, with dependencies already built by focused tests.
  • CI: green for the reviewed head, including the Console browser suite, site tests, Linux tests and macOS gate.

Test seams

  • Peek::new and its rendered HTML from Command details JSON.
  • The Console's /peek response and Inbox rows from retained Command records.
  • thirdshift show <command> --json from retained Command records.
  • Opening Command details from an Inbox row in Chromium, including phone widths.

Review

Independent reviews against main: Standards 0 findings; Spec 0 findings. Both axes read all 11 changed files and their supporting context. No generated-output exclusions. Unread changed files: none on either axis. Reports and summary.json are saved under .thirdshift-review-dhYFuJ/ for the Session trace.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Reverting restores the previous heading; no stored records or JSON schema change.

Blast Radius: Console

Command details heading and shared presentation visibility, with matching documentation and regression tests.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit fff8895 into main Oct 27, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1408 branch October 27, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command details opens with the issue and its title

1 participant