Repository navigation
Dismiss Inbox rows inline with d and Undo - #1418
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse the existing CSRF, pending, error and live-refresh flow. Keep Dismiss and
Undo in Command details, full row forms without JavaScript, and the row button
reachable on a phone. Update the Console manual and public site.
Closes #1407
Evidence
node --test --test-name-pattern='inline Dismiss leaves' console/tests/inbox.test.cjsfailed: the hidden Dismiss button could not be clicked. The site documentation regression also failed on the details-only wording.After: all 51 Inbox browser tests passed. After the review cleanup, the 7 Dismiss/Undo/keyboard/phone regressions passed again, covering both eligible groups, next selection, typing/dialog/modifier guards, error retries, live updates, notice expiry and no-JavaScript forms. The full Console suite (
npm test --prefix console) passed 103/103.d. Holding and releasing the export response reproduced the failure; waiting for the exported JSON before typing passed the controlled reproduction and full Console suite.scripts/affected-tests mainpassed: site browser tests 51/51 and the full Rust suite (cargo testfallback because nextest was unavailable)./usr/bin/time -p scripts/affected-tests mainmeasured 1601.45 s wall time, including compilation and site checks.cargo build --locked,cargo fmt --check, andgit diff --checkpassed.7a48a90f: Console, site, Linux Rust, macOS Rust and release-build CI checks passed; jobs excluded by workflow policy were skipped.Test seams
Review coverage
Independent Standards and Spec reviews used
git diff main...HEAD, withmainpinned to
edde830bdaaeeb8d683db7ba462ab3eab6ac2a41.Standards raised 1 possible Duplicated Code smell, addressed by sharing notice
cleanup. Spec raised 0 findings. Both follow-up reviews found no new findings.
Each reviewer read all 12 changed files,
including generated
site/docs/index.html. Generated exclusions: none.Changed files left unread by either axis: none.
Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the Console assets/templates and documentation to roll back.
Blast Radius: Console
Row layout, selection and Dismiss/Undo feedback share the existing server actions.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh