Skip to content

Dismiss Inbox rows inline with d and Undo - #1418

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1407
Oct 27, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1407

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Needs you / Ready for review
  row Dismiss or selected row + d
    POST /dismiss → select next row
    Dismissed <subject> · Undo
      POST /dismiss/undo → row returns

Reuse the existing CSRF, pending, error and live-refresh flow. Keep Dismiss and
Undo in Command details, full row forms without JavaScript, and the row button
reachable on a phone. Update the Console manual and public site.

Closes #1407

Evidence

  • Before: node --test --test-name-pattern='inline Dismiss leaves' console/tests/inbox.test.cjs failed: the hidden Dismiss button could not be clicked. The site documentation regression also failed on the details-only wording.
    After: all 51 Inbox browser tests passed. After the review cleanup, the 7 Dismiss/Undo/keyboard/phone regressions passed again, covering both eligible groups, next selection, typing/dialog/modifier guards, error retries, live updates, notice expiry and no-JavaScript forms. The full Console suite (npm test --prefix console) passed 103/103.
  • CI exposed a test race: the Theme export could overwrite the keyboard test's text before it pressed d. Holding and releasing the export response reproduced the failure; waiting for the exported JSON before typing passed the controlled reproduction and full Console suite.
  • scripts/affected-tests main passed: site browser tests 51/51 and the full Rust suite (cargo test fallback because nextest was unavailable). /usr/bin/time -p scripts/affected-tests main measured 1601.45 s wall time, including compilation and site checks.
  • cargo build --locked, cargo fmt --check, and git diff --check passed.
  • Final head 7a48a90f: Console, site, Linux Rust, macOS Rust and release-build CI checks passed; jobs excluded by workflow policy were skipped.

Test seams

  • Console browser interactions against the real local Console: row Dismiss, keyboard selection and guards, notice Undo, request feedback, live updates, and narrow/no-JavaScript layouts.
  • Public site browser rendering of the documented row action and shortcut.

Review coverage

Independent Standards and Spec reviews used git diff main...HEAD, with main
pinned to edde830bdaaeeb8d683db7ba462ab3eab6ac2a41.
Standards raised 1 possible Duplicated Code smell, addressed by sharing notice
cleanup. Spec raised 0 findings. Both follow-up reviews found no new findings.
Each reviewer read all 12 changed files,
including generated site/docs/index.html. Generated exclusions: none.
Changed files left unread by either axis: none.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the Console assets/templates and documentation to roll back.

Blast Radius: Console

Row layout, selection and Dismiss/Undo feedback share the existing server actions.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 9b2340b into main Oct 27, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1407 branch October 27, 2026 01:41
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dismiss an Inbox row without opening Command details

1 participant