Repository navigation
Add Console asset development mode - #1415
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom Theme assets retain their existing handling. CSP is unchanged. Askama templates and Rust still require a build. Development instructions are in
console/README.md.Closes #1397
Test seams: the Console binary's
/assets/*and/eventsHTTP routes; open Console pages in Playwright.Evidence
After: disk serving and confinement tests pass; CSS (including imported Theme CSS) swaps without navigation, stale responses cannot win, and scripts reload across Inbox, Logs, Account and Console log using one stream per tab. The Account reproducer now passes.
cargo test --release --test console assets::: 2 passed; release ignores the variable, retains embedded bytes after disk edits, and sends no asset events.cargo clippy --all-targets -- -D warnings: passed./usr/bin/time -p scripts/affected-tests main: full Rust suite passed (cargo testfallback); 1443.06 seconds wall time, including compilation.npm test --prefix console: all 98 browser tests passed (68.88 seconds), includingconsole/tests/assets.test.cjs.Merge Danger
Door: two-way
No persistent format or migration. Removing the variable restores embedded asset serving; release builds ignore it.
Blast Radius: Console
Shared stylesheet refresh and stream readiness also serve normal Console pages, covered by existing Theme and live-update tests.
Review coverage
Reviewed against
main(7b406d18): Standards 0 findings; Spec 1 finding, fixed and reproduced passing. Both reviewers read all 12 changed files, including the correction. No unread changed files or generated-output exclusions.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.