Repository navigation
docs(server): say only URI name constraints confine a URI SAN - #882
Merged
Merged
Conversation
AttesterIssuerInCertificate's doc said an attester could name another only through a CA under the anchors "or an intermediate without name constraints", which reads as if any name constraint closes the gap. RFC 5280 §4.2.1.10 applies each constraint to names of its own type, and crypto/x509 follows it: a CA constrained to the dNSName attester-a.example can still certify https://attester-b.example. Only uniformResourceIdentifier constraints confine a URI SAN, and then only its host. The doc now says so, and ClientAuthMethodTLSClientAuthSANURI notes the same for shared client CAs. A test pins the behaviour: under a shared anchor, attester A's dNSName-constrained CA attests for another attester's client, and a uniformResourceIdentifier constraint refuses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



AttesterIssuerInCertificatebinds an attester by a URI SAN equal to the client'sExpectedAttesterIssuer. Its doc said that, under shared anchors, an attester could name another one only through a CA under the anchors, "or an intermediate without name constraints". That reads as if any name constraint closes the gap.It doesn't. RFC 5280 §4.2.1.10 applies each constraint type to names of its own type only, and crypto/x509 follows it. So a sub-CA constrained to the
dNSNameattester-a.examplecan still certifyhttps://attester-b.example. A deployer who puts DNS constraints on each attester's CA in a shared pool and picks this mode lets one attester authenticate as another's clients.Change
AttesterIssuerInCertificatedoc: onlyuniformResourceIdentifierconstraints, on the attester's CA or one above it, confine a URI SAN, and then only its host. It still recommendsAttesterIssuerBoundToAnchorfor shared trust lists.ClientAuthMethodTLSClientAuthSANURIdoc: one added sentence saying the same applies to shared client CAs.TestX5CAttesterChainIssuerInCertificateNameConstraintsuses a shared anchor, where attester A's CA issues a certificate naming the client's attester:dNSNameconstraint for A's host, the request is accepted;uniformResourceIdentifierconstraint for A's host, it is refused withinvalid_client.No behaviour change.
🤖 Generated with Claude Code