Repository navigation
Conversation
Add EID value types, an additive KV schema for provider-written EIDs with owner and expiry, EID-level fields on the OpenRTB Eid, and a resolver that serves only live UIDs to auctions, x-ts-eids, identify and the admin auction preview. Auction EIDs merge per (source, inserter, matcher, mm, ext) with first-occurrence UID dedupe. KV writes over 16 KiB are refused. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Top-level document navigations on the publisher route receive a single-use write permit; finalize plans one row change (browser ingest, provider results, prune, size cap) and commits it once without retry. Non-navigation requests and redirects never write, integration proxies no longer mint ECs, and new ECs are created by the page-load write instead of at generation. Withdrawal tombstones only the active EC and keeps the EC cookie when the tombstone does not land; the withdrawal completion marker is the one deliberate extra write. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Add the IdentityProvider/ProviderKind interface and [[ec.identity_providers]] config, response validation, a deadline-bounded LookupTransport over select_until, the IdentityCoordinator with consent, allowlist and budget checks, the trusted-server-identity-providers crate (no kinds yet), and Fastly wiring that dispatches before the origin fetch and collects before the single page-load write. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Orphan recovery minted a new EC ID and then discarded the navigation's provider results because they were looked up under the orphaned ID. Lookups depend on the browser, not the EC ID, and the orphan has no row, so retarget them to the replacement as the spec requires. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Collection that starts after its deadline takes one nonblocking snapshot. A request still in the headers state moved to the body state without reading bytes, which counted as no progress, so a response that had fully arrived was abandoned unread and reported as a timeout. Count entering the body state as progress. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
A response body the host already holds can report not ready until the host services async I/O once, so an expired snapshot abandoned identity responses that arrived well before the deadline and reported them as timeouts. Give each pending body one host select capped at 1 ms before abandoning it. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
…not fill Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Page-load writes only run on real navigations, which browsers mark with both sec-fetch-dest: document and sec-fetch-mode: navigate. Without the mode header the consent withdrawal scenario never got a write permit, so the EC cookie was kept. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
A lookup sends the EC ID to the provider before finalize can decline the EC, so GPC, sale opt-out and unknown-jurisdiction requests must not dispatch. Matches the gate pull sync already applies. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
… read LiveRamp envelopes are about 700 bytes, so the 512-byte limit dropped every one from KV and the auction. Rows written under a higher limit now load with the oversized IDs removed instead of failing as a whole. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
304f395 to
2de6d0d
Compare
|
@dhruv8sh, directionally the layout here is not compatible with V2 (the 55 pull requests tracked in #777, merged in order). This pull request creates one shared The V2 spec is identifier-modules and pluggable-providers, with the folder layout in integrations-crate, all in #1342. The associated pull requests are #1382 (a module hands core its identifiers, starting with the Prebid EID cookie) and #1343 (the Edge Cookie as a module, with the HMAC module built in). Could you evaluate the V2 spec and those pull requests before progressing this one? |
…readable rows Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
…or gate Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Seeds a live row for the other EC so the EC-changed guard is the only thing that stops the after-response send, fixes doc comments that predate startup-built coordinators and the default Ec budgets, and moves tests out from between use lines. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
…cookie timing The vendor gate covers browser IDs and disabled providers and is lost when a provider entry is removed; an orphan-recovered row gets no after-response lookups; ts-ec is expired only once the tombstone lands while the pull-sync marker is expired on every withdrawal. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Aligns the status line, redirect rule, write table, UID and ext limits, coordinator trait, WritePlanInput sketch, rate-limit wording, disabled-provider gate, classify visibility, outcome logs, compatibility list, PR split and scenario 1 with the code, and links the deferrals to their issues. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
|
Round-3 review-body items:
|
Round 4 found nothing blocking. State in section 5.2.1 that the after-response phase skips its read when no result can change the row. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
A disabled provider's TCF vendor ID was dropped from the egress gate when an enabled provider claimed the same source, so the disabled provider's stored UIDs were served with only the new owner's vendor consent, or with none. The partner now keeps every configured provider's vendor ID and withholds the source unless each has consent. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
…sponse Signed-off-by: dhruv8sh <dhruv8sh@proton.me> # Conflicts: # crates/trusted-server-core/src/config.rs
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
prk-Jr
left a comment
There was a problem hiding this comment.
Summary
Round 3 from me, at 1600781. My round-2 blockers are fixed, and so is the over-cap blocker from aram356's round 3. This pass covered every commit since 4e7a6e0, the merge with main, and the production changes between 889159c and 4e7a6e0. No blocking findings.
Round-2 findings
| Finding | Status |
|---|---|
| Config push with an enabled provider takes the service down | Fixed: validate, push and diff reject any enabled provider |
| Vendors sent EC IDs that have no row | Fixed |
| Disabling or removing a provider drops its vendor gate | Disabled: fixed, now also on a source another provider claims. Removed: tracked in #1548, and the docs say to keep the entry with enabled = false |
| Spec has no review log | Fixed |
| Client copies bypass vendor consent; cookie UIDs of 513 to 1024 bytes | Fixed, tested at both auction call sites |
| Tombstone retry keeps the cookie; re-read when nothing changes | Documented; fixed |
| 64 KiB response limit applied after buffering | Tracked in #1550 |
Checked in this pass
- Over-cap rows (4f946fc): traced each branch. An ID added to a row written on main lands. This navigation's browser UIDs make way for provider UIDs. A refresh that no longer fits keeps the stored record, and trimming alone never writes.
- Reassigned source (92ae178): a source now goes out only while every configured provider's vendor has consent. This holds back a new owner's fresh UIDs while the disabled provider's vendor lacks consent. Each
KvUidalready records itsowner, so #1548's owner-based egress would make this exact. - Remembered opt-out (e6b22d2):
remember_opt_outkeeps the original end time, so writes don't extend the 30 days. - Merge with main: the
config.rsconflict was imports only. Provider config already usesdeny_unknown_fields, so a misspelledtcf_vendor_idfails at load and can't silently drop the gate. - 1600781: test-only. It builds the jar cookie with
Secure, and the test checks the same outcome.
Non-blocking
⛏ nitpick
- Say that a shared source needs every vendor's consent.
docs/guide/configuration.md(around lines 915-924) describes one provider's gate. Since 92ae178, a source claimed by several configured providers is withheld unless all their vendors consent. An operator moving a source from vendor A to vendor B would see B's IDs held back for visitors who consented to B only. One sentence after the/_ts/api/v1/identifysentence would cover it, for example: "When several configured providers claim a source, its IDs are sent only while every one of their vendors has consent."
CI Status
- Local at 1600781:
cargo fmt --all -- --checkclean; corepublisher::and auction-endpoint tests 466 passed, 0 failed; core clippy with tests and-D warningsclean. At 22f7045, the core EC, settings and config tests passed (1488). - Hosted at 1600781, when this review was submitted: 14 pass, CodeQL neutral, and 11 still running or queued (including
cargo test, the parity suite and vitest). This approval does not cover their results. - At 22f7045,
cargo test (ts CLI, native) (macos-latest)failed inbrowser_collector::tests::exhausted_page_settle_budget_still_polls_gpt_registry. This PR doesn't touch the CLI and the Ubuntu run passed, so it looks unrelated.
Reverse the provider stack to #1487, #1488, #1489 and refresh the moved heads. Split the EdgeZero release so Axum serving does not wait for the record contract (R1b), add the ClientInfo contract (EZI-3) and JA4 (IABTechLab/edgezero#283) that ID-7 needs on Axum, and move the Axum side of providers, abuse protection and SharedID write-back into A10 so Fastly no longer waits on the Axum chain. Drop blockers that code at the PR heads shows are already met (#1189, #1556, #1141 before A1), move four-adapter and decision-gated issues out of the MVP, and align priorities and sizes. The MVP is now waves 0 to 9.
|
CREATOR: From the server-side identity plan (#1559, |
Summary
atype,ext) and serves them unchanged into OpenRTB and Prebid, so bidders see the same shape the provider returned.This PR registers no provider kinds yet, so none of the provider paths run in production until the vendor PR lands. Follow-up PRs stack on this branch: mirror/pull sync (#1489), then the per-vendor provider implementations (#1488).
Changes
ec/eid_types.rs,ec/kv_types.rs,ec/kv.rs,openrtb.rs,ec/prebid_eids.rsec/write_plan.rs,ec/page_load.rs,ec/finalize.rs,publisher.rsec/provider.rs,ec/coordinator/*,ec/registry.rs,settings.rs,config.rs, newtrusted-server-identity-providerscrate, adapterapp.rs/main.rsec/coordinator/after_response.rs, adaptermain.rsdocs/guide/configuration.md,docs/guide/edge-cookies.md,docs/guide/integrations/prebid.md,trusted-server.example.tomlec.identity_providersconfiguration docs and exampledocs/superpowers/specs/2026-10-30-s2s-eid-collection-design.mdCollection
collect = "page"(default) runs before the response withinidentity_budget_ms(default 200).collect = "after_response"runs after the response is sent withinidentity_after_response_budget_ms(default 2000).tcf_vendor_id, when set, is checked only where GDPR applies or a TCF string is present. A KV read failure skips every provider. When a provider's vendor consent is denied, its stored IDs are also withheld from bidders,x-ts-eidsand/identify.opt_outsfield on the row, and the provider is not called again until it lapses. Older builds ignore the field.rate_limit_per_houris per EC hash, so clearing cookies does not reset it. On Fastly it is enforced per minute with a minimum of one, so values below 60 behave like 60.Storage and writes
ts-eidscookie, so an opted-out ID cannot come back from the browser.main) and expires the cookie once every tombstone is in place.row_fulland continues.Behaviour changes from
mainSec-Fetch-Dest: documentandSec-Fetch-Mode: navigate, the same check that permits its row write. Clients that send no Fetch Metadata no longer get a new EC./auctionor page-bids request body go to bidders but are never persisted.user.idand no provider lookup runs for it until a later navigation finds its row.Cleanup
ProviderResponsedebug output hides the body and any request context.Closes
Part of #1246 and #1245; the provider implementations that close them come in follow-up PRs.
Spec
Spec:
docs/superpowers/specs/2026-10-30-s2s-eid-collection-design.md, included in this PR.Test plan
cargo test-fastly && cargo test-fastly-reuse && cargo test-axum && cargo test-cloudflare && cargo test-spinclippy-fastly,-axum,-cloudflare,-cloudflare-wasm,-spin-native,-spin-wasm,-cli,-codegen)cargo fmt --all -- --checkscripts/lint-wasm-clock.shcd crates/trusted-server-js/lib && npx vitest run(plusnpm run formatandnpm run lint)./scripts/test-cli.sh, domain lint againstorigin/main, CI Node pin guard, docs-proposal scriptsfastly compute serveChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)Closes #1567