Repository navigation
refactor(mcp_readability): group the scorer modules into a package - #637
Merged
Merged
Conversation
The readability scorers have grown to four modules sitting flat in scorers/, with more coming. Move them under scorers/mcp_readability/ the way dataset_quality is laid out, and give the package the scorer registry so the orchestrator imports one entry point instead of each module. Pure move: no behavior change, and the scorer names in the run config are untouched.
akangsha7
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
September 30, 2026 16:58
helloeve
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review comment on #623: the readability scorers had grown to four modules sitting flat in
scorers/, with carry-forward and CUJ coverage still to come. This lays them out the waydataset_qualityis, as a pure move so #623 stays a review of its own logic.Changes
scorers/mcp_readability/(new package) —mcp_readability_scoring.py→scoring.py,mcp_fingerprint.py→fingerprint.py,mcp_style_readability.py→style_readability.py,mcp_tool_metrics.py→tool_metrics.py. Contents are unchanged apart from their own imports.scorers/mcp_readability/registry.py(new) —SCORER_REGISTRYmoves out of the orchestrator, so the package is the one thing a caller imports. It is a registry rather than a single top-level scorer class likeDatasetQualityScorer:mcp_tool_metricsandmcp_style_readabilityare separately registered names that appear underscorers:in the run config and as thecomparatoron their summary rows, so collapsing them behind one scorer would change the config surface and the dashboard rows.evaluator/mcp_readability/orchestrator.py— imports the registry instead of the scorer classes; docstring module paths updated.patchtargets are strings (scorers.mcp_style_readability.get_generator), so those were swept for separately; a stale one would silently patch nothing rather than fail.Scorer names in
run_config.yamlare unchanged, so the google3 mirror and Guitar are unaffected.PYTHONPATH=$PWD/evalbench:$PWD uv run --with pytest pytest evalbench/test— 783 passed.bigtable_testfails with a GCPPermissionDenied, which reproduces onmainand is unrelated.