feat(mcp_readability): decide what a run can reuse from its baseline - #623
Merged
Merged
Conversation
akangsha7
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
September 21, 2026 18:56
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 28, 2026 19:24
638cb78 to
1909c0a
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
2 times, most recently
from
September 28, 2026 23:33
9a4e63f to
96c0e72
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 29, 2026 03:34
1909c0a to
17df0c4
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 03:34
96c0e72 to
29831c6
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 29, 2026 03:44
17df0c4 to
04a7f60
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 03:44
29831c6 to
efbd5a7
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 29, 2026 04:32
04a7f60 to
d16f9c7
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 04:32
efbd5a7 to
79cc805
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 29, 2026 04:46
d16f9c7 to
0b9373e
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 04:46
79cc805 to
b78f588
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-baseline-store
branch
from
September 29, 2026 05:11
0b9373e to
d9aca3e
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 05:11
b78f588 to
f9e455e
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 29, 2026 19:18
f9e455e to
a555915
Compare
Base automatically changed from
evalbench/mcp-readability-baseline-store
to
main
September 29, 2026 19:42
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
10 times, most recently
from
September 30, 2026 01:06
baabe21 to
39b447a
Compare
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 30, 2026 03:02
39b447a to
0ba1389
Compare
helloeve
requested changes
Sep 30, 2026
helloeve
left a comment
Collaborator
There was a problem hiding this comment.
It seems to me that MCP readability scorers are having multiple modules now, can we move the dependent modules into a dedicated directory under scorers? (similar to the dataset_quality one) and under scorers there is a top-level mcp-readability scorer which reference those modules?
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
September 30, 2026 19:59
0ba1389 to
34f3752
Compare
akangsha7
changed the base branch from
main
to
evalbench/mcp-readability-scorers-package
September 30, 2026 19:59
Base automatically changed from
evalbench/mcp-readability-scorers-package
to
main
October 1, 2026 19:24
Given a baseline and this run's fingerprints, work out which tools still hold and which have to be re-judged, merge the carried findings with the fresh ones, and record where each finding came from. Pure functions only: nothing calls them yet, so a run still judges every endpoint in full.
akangsha7
force-pushed
the
evalbench/mcp-readability-carry-forward
branch
from
October 1, 2026 19:30
44d8651 to
8409098
Compare
helloeve
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #637, which moved these modules into scorers/mcp_readability/. Follows #622 and #615, both now merged.
Summary
#622 records the judge's inputs and #615 reads the previous run's back. This is the logic between them: given a baseline and this run's fingerprints, decide which tools still hold, which must be re-judged, and what explains the difference. Pure functions — nothing calls them yet, so a run still judges every endpoint in full.
The invariant: same endpoint, same per-tool fingerprints, same judge fingerprint means byte-identical feedback and zero model calls. Every departure gets a named reason from an exact set-difference, not a guess.
Changes