Skip to content

Fix: reusable-sf-code-analyze pinned a Node the SF CLI no longer runs on #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gambe94 merged 1 commit into from
Aug 14, 2026
Merged

Fix: reusable-sf-code-analyze pinned a Node the SF CLI no longer runs on #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/reusable-sf-code-analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,17 @@ on:
default: false
type: boolean
node-version:
description: 'Node.js version to use'
description: >-
Node.js version. Must satisfy the SF CLI's own engines field — this
job installs @salesforce/cli, and the CLI now requires >= 22.
required: false
default: '20.9.0'
# Was pinned at '20.9.0'. That exact pin is how this broke: the CLI is
# unpinned here, so when it raised its engines floor to >=22 the pair
# drifted apart and every consumer's static-analysis job started failing
# with `npm WARN EBADENGINE` followed by a bare `exit code 1`. Tracking
# the major (and matching what the sf-docker-images pin) keeps the two
# moving together.
default: '24'
type: string
java-version:
description: 'Java version to use'
Expand Down
Loading