Repository navigation
Fix: reusable-sf-code-analyze pinned a Node the SF CLI no longer runs on - #31
Merged
Merged
Conversation
The workflow installs `@salesforce/cli` unpinned but pinned `node-version` to
the exact string `20.9.0`. The CLI has since raised its engines floor to
`>=22.0.0`, so the two drifted apart and the job now fails for every consumer:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@salesforce/cli@2.147.7',
npm WARN EBADENGINE required: { node: '>=22.0.0' },
npm WARN EBADENGINE current: { node: 'v20.9.0', npm: '10.1.0' }
followed by a bare `##[error]Process completed with exit code 1` — the warning
is the only thing naming the cause, and it is a WARN, so it reads as noise.
Default is now `24`, matching what all three sf-docker-images pin. Tracking the
major rather than an exact patch is deliberate: an exact pin beside an unpinned
dependency is what produced the drift.
Found from sf-develop-demo, whose new thin PR gate calls this workflow and could
not get past static analysis.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-versionwas pinned to the exact string20.9.0while@salesforce/cliis installed unpinned. The CLI raised its engines floor to>=22.0.0, so the pair drifted and static analysis now fails for every consumer:…then a bare
##[error]Process completed with exit code 1. The only line naming the cause is aWARN, so it reads as noise.Default is now
24, matching what all three sf-docker-images pin. Tracking the major rather than an exact patch is the point — an exact pin sitting beside an unpinned dependency is what caused the drift.Found from
sf-develop-demo, whose new thin PR gate calls this workflow and could not get past static analysis.Needs the
v2tag moved before consumers pick it up — same as #30.🤖 Generated with Claude Code