Skip to content

Add 8 MacBook Pro models from 2016-2019 (Intel) from Wikipedia - #270

Merged
Seungpyo1007 merged 1 commit into
developfrom
data/macbook-pro-2016-2019
Sep 25, 2026
Merged

Seungpyo1007 merged 1 commit into
developfrom
data/macbook-pro-2016-2019

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #268. It adds the 8 MacBook Pro models from 2016, 2018 and 2019 (13-inch with two or four Thunderbolt 3 ports, and 15-inch) from MacBook Pro (Intel-based). Their table puts RAM under "Processor | Memory | Capacity", which the first pass missed. Fields and the base-configuration rule are the same as #268 (first standard column, education SKUs skipped). The 2017 models stay out because they exist as variant groups.

Spot-checked: 15" 2016 i7-6700HQ, 16 GB, Radeon Pro 450, $2,399; 13" 2019 two-port i5-8257U, $1,299.

Closes #1

@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

551 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 540
    "Yellow" : 11
    "Red" : 0
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨🟨 13 7 6 0 53.8%
soc 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 20 20 0 0 100.0%
smartphone 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨 38 37 1 0 97.4%
tablet 🟩🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨 10 7 3 0 70.0%
watch 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 4 4 0 0 100.0%
pda 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 1 0 0 100.0%
gpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨 75 74 1 0 98.7%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 390 390 0 0 100.0%
All 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨 551 540 11 0 98.0%

Full-dataset baseline

106245 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 24045
    "Yellow" : 81104
    "Red" : 1096
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 207 122 85 0 58.9%
soc 🟩🟨🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥 2097 251 824 1022 12.0%
smartphone 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93396 17931 75397 68 19.2%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 291 3163 1 8.4%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 43 386 4 9.9%
pda 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 140 83 57 0 59.3%
gpu 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 2093 1274 819 0 60.9%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟥 4424 4050 373 1 91.5%
All 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟥 106245 24045 81104 1096 22.6%

Hard violations (forced red):

Count Check
1 !boost_ge_base

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
New hard integrity anomalies vs PR base PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 122 85 0 207 58.9%
soc 2097 193 1904 0 2097 9.2%
smartphone 93396 17501 75895 0 93396 18.7%
tablet 3455 273 3182 0 3455 7.9%
watch 433 39 394 0 433 9.0%
pda 140 74 66 0 140 52.9%
gpu 2093 1028 1065 0 2093 49.1%
cpu 4424 2869 1555 0 4424 64.9%
all 106245 22099 84146 0 106245 20.8%

Warning

Tracked verified coverage is below 50% for tablet 7.9% (273/3455), watch 9.0% (39/433), soc 9.2% (193/2097), smartphone 18.7% (17501/93396), all 20.8% (22099/106245), gpu 49.1% (1028/2093).
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • The integrity gate blocks only hard anomalies introduced by this PR relative to its merge base.
  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py (PR head compared with PR base)
loaded CPU=4424 GPU=2093
Integrity section Flagged lines
structural 20
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 155
GPU cross-source ratio outliers + sanity 18

@Seungpyo1007
Seungpyo1007 merged commit a57c7a6 into develop Sep 25, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the data/macbook-pro-2016-2019 branch September 25, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechAPI dataset roadmap and status: all categories (1989-2026)

2 participants